Skip to content

removed template args from the constructor declarations#1011

Closed
luxapana wants to merge 3 commits intoopen-telemetry:mainfrom
luxapana:1010
Closed

removed template args from the constructor declarations#1011
luxapana wants to merge 3 commits intoopen-telemetry:mainfrom
luxapana:1010

Conversation

@luxapana
Copy link
Copy Markdown

Fixes # (1010)

Changes

Please provide a brief description of the changes here.

Removed template params from constructor declaration to comly with c++20 standard.

@luxapana luxapana requested a review from a team October 12, 2021 04:07
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Oct 12, 2021

CLA Missing ID

Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. You have to sign the CLA to get this through :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 12, 2021

Codecov Report

Merging #1011 (321c365) into main (cc065f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         151      151           
  Lines        5972     5972           
=======================================
  Hits         5664     5664           
  Misses        308      308           

@luxapana
Copy link
Copy Markdown
Author

Can some one please let me know some info on how to fix two failures above? format and EasyCLA. I did signed the agreement however.

@lalitb
Copy link
Copy Markdown
Member

lalitb commented Oct 15, 2021

Can some one please let me know some info on how to fix two failures above? format and EasyCLA. I did signed the agreement however.

easyCLA: https://docs.linuxfoundation.org/lfx/easycla/v1-deprecated/contributors/individual-contributor
formatting: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/CONTRIBUTING.md#how-to-send-pull-requests

If you have already signed the agreement, probably it gets fixed with the next commit to this PR. Let us know if it doesn't work.

@ThomsonTan
Copy link
Copy Markdown
Contributor

@manushawijekoon do you still need more instructions to fix CLA and format?

@lalitb
Copy link
Copy Markdown
Member

lalitb commented Oct 27, 2021

#1029 fixes this issue, so closing the PR.

@lalitb lalitb closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants