Change OTLP/HTTP default port from 4317 to 4318#1018
Merged
ThomsonTan merged 2 commits intoopen-telemetry:mainfrom Oct 19, 2021
Merged
Change OTLP/HTTP default port from 4317 to 4318#1018ThomsonTan merged 2 commits intoopen-telemetry:mainfrom
ThomsonTan merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1018 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 161 161
Lines 6833 6833
=======================================
Hits 6519 6519
Misses 314 314 |
ThomsonTan
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the changes in the specs: open-telemetry/opentelemetry-specification#1970
This could be the BREAKING change, but since the collector never moved to 4317 for grpc-http ( as per its commit history ), it shouldn't affect many customers.
Note: this is still in process of reservation with IANA (open-telemetry/opentelemetry-specification#1970 (comment) )
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes