Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 151 151
Lines 5971 5971
=======================================
Hits 5663 5663
Misses 308 308 |
lalitb
approved these changes
Nov 5, 2021
| */ | ||
|
|
||
| OPENTELEMETRY_BEGIN_NAMESPACE | ||
| namespace sdkmetrics = opentelemetry::sdk::metrics; |
Member
There was a problem hiding this comment.
nit: not recommended to use the namespace alias in the header file, as it becomes part of public API. It's been used all over the code right now and #1008 should be fixing it.
ThomsonTan
reviewed
Nov 5, 2021
|
|
||
| ## [1.0.1] 2021-10-21 | ||
|
|
||
| * [EXPORTER] Prometheus Exporter ([#1031](https://github.com/open-telemetry/opentelemetry-cpp/pull/1031)) |
Contributor
There was a problem hiding this comment.
This should be put into the above section for "Unreleased".
ThomsonTan
reviewed
Nov 5, 2021
| make test | ||
| exit 0 | ||
| elif [[ "$1" == "cmake.legacy.test" ]]; then | ||
|
|
Contributor
There was a problem hiding this comment.
nit: remove this empty line.
ThomsonTan
reviewed
Nov 5, 2021
| cmake -DCMAKE_BUILD_TYPE=Debug \ | ||
| -DCMAKE_CXX_FLAGS="-Werror" \ | ||
| -DCMAKE_CXX_STANDARD=11 \ | ||
| -DCMAKE_EXE_LINKER_FLAGS="-lpthread" \ |
Member
ThomsonTan
reviewed
Nov 5, 2021
| include_directories(include) | ||
| find_package(prometheus-cpp CONFIG REQUIRED) | ||
|
|
||
| add_library(prometheus_exporter_deprecated src/prometheus_collector.cc |
Contributor
There was a problem hiding this comment.
The target is removed here, but I didn't see it is added back in other places but it is referenced below in target_include_directories.
Member
Author
ThomsonTan
reviewed
Nov 5, 2021
| @@ -0,0 +1,111 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
Simplify the copyright header as below?
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to finish #263
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes