Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1119 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 165 165
Lines 6229 6229
=======================================
Hits 5817 5817
Misses 412 412 |
lalitb
reviewed
Dec 8, 2021
| build systems for opentelemetry-cpp. | ||
|
|
||
| ## Dependencies | ||
|
|
Member
There was a problem hiding this comment.
There is also a more detailed dependencies doc here ( https://github.com/open-telemetry/opentelemetry-cpp/blob/main/docs/dependencies.md).
Can we add a reference to the above doc along with https://github.com/open-telemetry/opentelemetry-cpp/blob/main/third_party_release for versions in this section? This way we don't need to list out the libraries again here.
Member
Author
There was a problem hiding this comment.
oh, how I missed this file :).
Thanks, I removed the libs.
lalitb
approved these changes
Dec 8, 2021
ThomsonTan
reviewed
Dec 8, 2021
ThomsonTan
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1108 (issue)
Changes
Please provide a brief description of the changes here.
Adds dependencies to INSTALL.md.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes