Rename OTEL_CPP_GET_ATTR macro, and define it using fully qualified attr function.#1140
Merged
lalitb merged 3 commits intoopen-telemetry:mainfrom Dec 20, 2021
Merged
Conversation
attr function.
Codecov Report
@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 93.39% 93.38% -0.01%
==========================================
Files 165 165
Lines 6229 6230 +1
==========================================
Hits 5817 5817
- Misses 412 413 +1
|
ThomsonTan
approved these changes
Dec 20, 2021
This was referenced Jan 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1139
Changes
resourceandtraceinto two different sem-ver macros - OTEL_GET_TRACE_ATTR (for trace) and OTEL_GET_RESOURCE_ATTR (for resource). This will avoid name overwriting if both are used in the same application.attrfunction.this may break applications that have been using earlier macros. While existing macros can be kept, it's better to clean up as the impact is minimal.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes