Skip to content

Update OpenTelemetry protobuf definitions#140

Merged
reyang merged 6 commits intoopen-telemetry:masterfrom
nadiaciobanu:update-protos
Jul 2, 2020
Merged

Update OpenTelemetry protobuf definitions#140
reyang merged 6 commits intoopen-telemetry:masterfrom
nadiaciobanu:update-protos

Conversation

@nadiaciobanu
Copy link
Copy Markdown
Contributor

Our vendored version of opentelemetry-proto is out of date with https://github.com/open-telemetry/opentelemetry-proto. This PR updates it with the most recent version. This update is required for the OTLP exporter.

@nadiaciobanu nadiaciobanu requested a review from a team June 30, 2020 20:08
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2020

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          71       71           
  Lines        1724     1724           
=======================================
  Hits         1612     1612           
  Misses        112      112           

Copy link
Copy Markdown
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. It's important to get this in place before doing any work on attributes.

@nadiaciobanu
Copy link
Copy Markdown
Contributor Author

@reyang Ready to merge :)

@reyang reyang merged commit 7486a29 into open-telemetry:master Jul 2, 2020
nadiaciobanu added a commit to nadiaciobanu/opentelemetry-cpp that referenced this pull request Jul 2, 2020
@nadiaciobanu nadiaciobanu deleted the update-protos branch July 10, 2020 23:01
@reyang reyang mentioned this pull request Aug 25, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants