Inline print_value() in ostream exporter#1512
Merged
esigo merged 2 commits intoopen-telemetry:mainfrom Jul 24, 2022
Merged
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## main #1512 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 155 155
Lines 4781 4781
=======================================
Hits 4050 4050
Misses 731 731
|
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The common_utils.h header is being used in multiple build targets in the ostream exporter. This header defines the print_value() function, and because it's not inlined, it causes the build to fail in case it tries to link to more than one ostream exporter.
Solution: inline function.