Add configuration options for Aggregation creation#1513
Add configuration options for Aggregation creation#1513esigo merged 15 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 84.63% 84.65% +0.03%
==========================================
Files 155 156 +1
Lines 4781 4794 +13
==========================================
+ Hits 4046 4058 +12
- Misses 735 736 +1
|
|
Thanks for the PR. Changes are nicely done. One suggestion - Should we expose the config api in the SDK and not the API. As of now, the instrumentation library shouldn't be able to specify the metrics configuration, it should be done only by SDK (through View API?). There have been some discussions earlier to expose the config through API - Configuring histograms in the API (hints?), Add the metrics API Hint - but was not added to specs. |
@lalitb thanks, removed from api. |
Fixes #1444 (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes