Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 71 71
Lines 1754 1754
=======================================
Hits 1642 1642
Misses 112 112 |
IlyaKobelevskiy
approved these changes
Jul 3, 2020
pyohannes
reviewed
Jul 3, 2020
g-easy
reviewed
Jul 6, 2020
Contributor
Author
|
@pyohannes Please let me know if you have any other comments! |
pyohannes
approved these changes
Jul 7, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
This looks good. I have two more nits, otherwise this is ready to merge.
pyohannes
reviewed
Jul 7, 2020
Contributor
Author
|
@reyang Ready to merge! |
Member
|
@nadiaciobanu would you rebase? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an OTLP exporter that exports spans to the OpenTelemetry Collector via gRPC. Note that this requires adding a gRPC dependency to
opentelemetry-cpp.