METRICS SDK - Calling Observable Instruments callback during metrics collection#1554
Merged
ThomsonTan merged 10 commits intoopen-telemetry:mainfrom Aug 15, 2022
Merged
METRICS SDK - Calling Observable Instruments callback during metrics collection#1554ThomsonTan merged 10 commits intoopen-telemetry:mainfrom
ThomsonTan merged 10 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
+ Coverage 83.38% 85.02% +1.64%
==========================================
Files 156 156
Lines 4975 4977 +2
==========================================
+ Hits 4148 4231 +83
+ Misses 827 746 -81
|
Member
|
is this finished? |
Member
Author
Yes changes are fine, as I tested with ostream exporter, I need to add unit test. Will be finishing it today. |
Member
Author
I have now added basic tests to validate the async flow, it should be good to review now. |
esigo
reviewed
Aug 13, 2022
ThomsonTan
reviewed
Aug 15, 2022
ThomsonTan
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1550, #1556
Changes
Please provide a brief description of the changes here.
Meter::Collect()), call all the registered callbacks once.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes