Skip to content

Add badges to README.md#157

Merged
reyang merged 2 commits intoopen-telemetry:masterfrom
huyan0:add-badge
Jul 8, 2020
Merged

Add badges to README.md#157
reyang merged 2 commits intoopen-telemetry:masterfrom
huyan0:add-badge

Conversation

@huyan0
Copy link
Copy Markdown
Member

@huyan0 huyan0 commented Jul 7, 2020

This PR adds status badges for repo license, build status and code coverage to README.md
This is useful for all developers to get a at-a-glance status of the repository.

@huyan0 huyan0 requested a review from a team July 7, 2020 23:09
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jul 7, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2020

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          71       71           
  Lines        1754     1754           
=======================================
  Hits         1642     1642           
  Misses        112      112           

@reyang
Copy link
Copy Markdown
Member

reyang commented Jul 7, 2020

The visual seems inconsistent, and there is a line break which we want to remove:

image

@reyang
Copy link
Copy Markdown
Member

reyang commented Jul 7, 2020

License info is already showing on the home page, we might want to avoid adding duplicated info:

image

Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Welcome to this project @huyan0 😄

@huyan0
Copy link
Copy Markdown
Member Author

huyan0 commented Jul 7, 2020

Thanks you! I changed the style of the badges and removed the heading "About this project" so that there is one less line break.

@reyang
Copy link
Copy Markdown
Member

reyang commented Jul 8, 2020

Please rebase and let's wait for a day for other folks to review and comment.

@huyan0 huyan0 marked this pull request as draft July 8, 2020 14:49
@huyan0 huyan0 marked this pull request as ready for review July 8, 2020 15:16
@reyang reyang merged commit 5bcf2d5 into open-telemetry:master Jul 8, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…e-3.x

Update dependency rules_apple to v3.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants