resource sdk: Update Resource::Merge function docs#1615
Merged
lalitb merged 1 commit intoopen-telemetry:mainfrom Sep 15, 2022
Merged
resource sdk: Update Resource::Merge function docs#1615lalitb merged 1 commit intoopen-telemetry:mainfrom
lalitb merged 1 commit intoopen-telemetry:mainfrom
Conversation
The documented behaviour of Resource::Merge is the opposite of what it actually does. As per https://cplusplus.com/reference/unordered_map/unordered_map/insert/, when calling `insert` on an unordered_map, each element is inserted only if its key is not equivalent to the key of any other element already in the container. Signed-off-by: ricekot <github@ricekot.com>
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
==========================================
- Coverage 85.30% 85.28% -0.02%
==========================================
Files 156 156
Lines 4978 4978
==========================================
- Hits 4246 4245 -1
- Misses 732 733 +1
|
lalitb
approved these changes
Sep 14, 2022
ThomsonTan
approved these changes
Sep 14, 2022
Contributor
Author
|
Signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented behaviour of Resource::Merge is the opposite of what it actually does.
As per https://cplusplus.com/reference/unordered_map/unordered_map/insert/, when calling
inserton an unordered_map, each element is inserted only if its key is not equivalent to the key of any other element already in the container.