Rename OnReceive to OnEmit#1652
Merged
ThomsonTan merged 1 commit intoopen-telemetry:mainfrom Oct 4, 2022
Merged
Conversation
Signed-off-by: owent <admin@owent.net>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 85.10% 85.02% -0.08%
==========================================
Files 159 159
Lines 4990 4990
==========================================
- Hits 4246 4242 -4
- Misses 744 748 +4
|
lalitb
approved these changes
Oct 4, 2022
esigo
approved these changes
Oct 4, 2022
ThomsonTan
approved these changes
Oct 4, 2022
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owent admin@owent.net
Fixes #1291
There are a lot changes of logs specification since #1291 . I think we can change
OnReceivetoOnEmitand close #1291 first. And we may need more discussion about the changes of logs API and SDK before the rest changes. #1653Changes
OnReceivetoOnEmitFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes