[Metrics SDK] Move Metrics Exemplar processing behind feature flag#1710
Merged
lalitb merged 5 commits intoopen-telemetry:mainfrom Oct 25, 2022
Merged
[Metrics SDK] Move Metrics Exemplar processing behind feature flag#1710lalitb merged 5 commits intoopen-telemetry:mainfrom
lalitb merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
+ Coverage 86.31% 86.32% +0.02%
==========================================
Files 169 169
Lines 5154 5146 -8
==========================================
- Hits 4448 4442 -6
+ Misses 706 704 -2
|
marcalff
approved these changes
Oct 25, 2022
| option(WITH_LOGS_PREVIEW "Whether to build logs preview" OFF) | ||
| option(WITH_ASYNC_EXPORT_PREVIEW "Whether enable async export" OFF) | ||
| option(WITH_METRICS_EXEMPLAR_PREVIEW | ||
| "Whethere to enable exemplar within metrics" OFF) |
Contributor
There was a problem hiding this comment.
And mentioned the spec status is experimental, so user will be aware of that instead of considering it as implementation gap?
ThomsonTan
approved these changes
Oct 25, 2022
ays7
added a commit
to ays7/opentelemetry-cpp
that referenced
this pull request
Oct 29, 2022
…ad-local-stack * commit '9acde87b08b225ce511fa8a20c6cba14f2921518': (36 commits) Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721) Fix: 1712 - Validate Instrument meta data (name, unit, description) (open-telemetry#1713) Document libthrift 0.12.0 doesn't work with Jaeger exporter (open-telemetry#1714) Fix:1674, Add Monotonic Property to Sum Aggregation, and unit tests for Up Down Counter (open-telemetry#1675) [Metrics SDK] Move Metrics Exemplar processing behind feature flag (open-telemetry#1710) [Metrics API/SDK] Change Meter API/SDK to return nostd::unique_ptr for Sync Instruments (open-telemetry#1707) [Metrics] Switch to explicit 64 bit integers (open-telemetry#1686) Add metrics e2e test to asan & tsan CI (open-telemetry#1670) Add otlp-grpc example bazel (open-telemetry#1708) [Metrics SDK] Add support for Pull Metric Reader (open-telemetry#1701) Fix debug log of OTLP HTTP exporter and ES log exporter (open-telemetry#1703) [SEMANTIC CONVENTIONS] Upgrade to version 1.14.0 (open-telemetry#1697) Fix a potential precision loss on integer in ReservoirCellIndexFor (open-telemetry#1696) fix Histogram crash (open-telemetry#1685) Fix:1676 Segfault when short export period is used for metrics (open-telemetry#1682) Add timeout support to MeterContext::ForceFlush (open-telemetry#1673) Add CMake OTELCPP_MAINTAINER_MODE (open-telemetry#1650) [DOCS] - Minor updates to OStream Metrics exporter documentation (open-telemetry#1679) Fix:open-telemetry#1575 API Documentation for Metrics SDK and API (open-telemetry#1678) Fixes open-telemetry#249 (open-telemetry#1677) ...
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exemplar are still experimental, so exemplar processing is moved behind feature flag macro -
ENABLE_METRICS_EXEMPLAR_PREVIEW. The exemplar would be processed in hot path only if the flag is enabled. The flag needs to be explicitly enabled in build script to use exemplars.This allows us
The CI tests still continue to test the full metrics functionality with feature flag enabled for both cmake and bazel.