Skip to content

Add option WITH_BENCHMARK to disable building benchmarks#1794

Merged
lalitb merged 8 commits intoopen-telemetry:mainfrom
ThomsonTan:with_benchmark
Nov 24, 2022
Merged

Add option WITH_BENCHMARK to disable building benchmarks#1794
lalitb merged 8 commits intoopen-telemetry:mainfrom
ThomsonTan:with_benchmark

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team November 23, 2022 00:18
Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and good idea.

@lalitb
Copy link
Copy Markdown
Member

lalitb commented Nov 23, 2022

Thanks, can we also add the "benchmark" tag for Bazel, it will allow to disable building benchmark test for bazel too.

refer -

tags = [
"api",
"test",
"trace",
],

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1794 (d964558) into main (c1aa0b8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1794   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         171      171           
  Lines        5240     5240           
=======================================
  Hits         4492     4492           
  Misses        748      748           

Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting similar changes for bazel as mentioned in comments :)

@ThomsonTan
Copy link
Copy Markdown
Contributor Author

Requesting similar changes for bazel as mentioned in comments :)

Done the change.

Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Much needed change :)

@lalitb lalitb merged commit 3f0eee6 into open-telemetry:main Nov 24, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants