[MAINTAINER DOC] Define and document a deprecation process#1923
Merged
lalitb merged 22 commits intoopen-telemetry:mainfrom Jan 30, 2023
Merged
[MAINTAINER DOC] Define and document a deprecation process#1923lalitb merged 22 commits intoopen-telemetry:mainfrom
lalitb merged 22 commits intoopen-telemetry:mainfrom
Conversation
Example of deprecation, for jaeger.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
- Coverage 87.12% 87.10% -0.02%
==========================================
Files 165 165
Lines 4596 4596
==========================================
- Hits 4004 4003 -1
- Misses 592 593 +1
|
Member
|
Thanks, a very well thought-out and documented process. This will indeed smoothen the deprecation process. Have few nit comments :) |
lalitb
reviewed
Jan 20, 2023
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
improved process doc.
Co-authored-by: Ehsan Saei <71217171+esigo@users.noreply.github.com>
Member
Author
|
Done with the last edits, now ready for formal review and merge. |
lalitb
approved these changes
Jan 26, 2023
Member
Author
Thanks, fixed.
Actually, this doc needs no changes. The This documentation is about setting up |
ThomsonTan
reviewed
Jan 26, 2023
ThomsonTan
reviewed
Jan 26, 2023
ThomsonTan
reviewed
Jan 26, 2023
ThomsonTan
reviewed
Jan 26, 2023
ThomsonTan
reviewed
Jan 26, 2023
ThomsonTan
reviewed
Jan 26, 2023
ThomsonTan
reviewed
Jan 26, 2023
Member
Yes, didn't realize it is using OTLP exporter to send the traces. |
Co-authored-by: Tom Tan <lilotom@gmail.com>
owent
approved these changes
Jan 29, 2023
ThomsonTan
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1893
Fixes #1892
Changes
This change contains:
MAINTAINER_MODEcode without deprecated items.Also, it contains the actual deprecation for the Jaeger Exporter:
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes