Small fix in INSTALL.md for enabling building package.#1930
Merged
lalitb merged 2 commits intoopen-telemetry:mainfrom Jan 18, 2023
Merged
Small fix in INSTALL.md for enabling building package.#1930lalitb merged 2 commits intoopen-telemetry:mainfrom
lalitb merged 2 commits intoopen-telemetry:mainfrom
Conversation
reyang
approved these changes
Jan 18, 2023
ThomsonTan
approved these changes
Jan 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
+ Coverage 86.90% 86.92% +0.03%
==========================================
Files 165 165
Lines 4594 4594
==========================================
+ Hits 3992 3993 +1
+ Misses 602 601 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
Fix documentation to use
cmake -DBUILD_PACKAGE=ON ..to configure building package.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes