Skip to content

Fix thread-safety when shutdown.#1977

Merged
lalitb merged 2 commits intoopen-telemetry:mainfrom
owent:fix_1976
Feb 10, 2023
Merged

Fix thread-safety when shutdown.#1977
lalitb merged 2 commits intoopen-telemetry:mainfrom
owent:fix_1976

Conversation

@owent
Copy link
Copy Markdown
Member

@owent owent commented Feb 10, 2023

Signed-off-by: owent admin@owent.net

Fixes #1976

Changes

Please provide a brief description of the changes here.

  • Do not reset curl handle and just wake background thread to finish the removing.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Signed-off-by: owent <admin@owent.net>
@owent owent requested a review from a team February 10, 2023 17:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2023

Codecov Report

Merging #1977 (5722d77) into main (9d8efaf) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
+ Coverage   87.10%   87.12%   +0.03%     
==========================================
  Files         165      165              
  Lines        4596     4596              
==========================================
+ Hits         4003     4004       +1     
+ Misses        593      592       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.48% <0.00%> (+0.78%) ⬆️

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Feb 10, 2023
@lalitb lalitb merged commit 6f0a30e into open-telemetry:main Feb 10, 2023
@owent owent deleted the fix_1976 branch February 15, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shutdown OTLP HTTP Exporters may crash in async mode.

4 participants