Skip to content

[SEMANTIC CONVENTIONS] Upgrade to version 1.19.0#2017

Merged
lalitb merged 7 commits intoopen-telemetry:mainfrom
marcalff:fix_sem_conv_2016
Mar 27, 2023
Merged

[SEMANTIC CONVENTIONS] Upgrade to version 1.19.0#2017
lalitb merged 7 commits intoopen-telemetry:mainfrom
marcalff:fix_sem_conv_2016

Conversation

@marcalff
Copy link
Copy Markdown
Member

@marcalff marcalff commented Mar 6, 2023 •
edited
Loading

Fixes #2016

Changes

Upgraded semantic conventions to 1.19.0

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team March 6, 2023 20:38
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #2017 (9a1b087) into main (3305bd7) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 9a1b087 differs from pull request most recent head ea980bf. Consider uploading reports for the commit ea980bf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
- Coverage   87.17%   87.15%   -0.02%     
==========================================
  Files         166      166              
  Lines        4746     4746              
==========================================
- Hits         4137     4136       -1     
- Misses        609      610       +1

see 1 file with indirect coverage changes

@marcalff
Copy link
Copy Markdown
Member Author

marcalff commented Mar 6, 2023

On hold for now, there is something wrong with code generation, a lot of semconv are missing.

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Mar 6, 2023
@marcalff marcalff mentioned this pull request Mar 6, 2023
Merged
@marcalff marcalff added pr:do-not-merge This PR is not ready to be merged. issue:blocked Fix blocked, waiting for other fixes as prerequisites and removed ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) labels Mar 6, 2023
@marcalff marcalff mentioned this pull request Mar 6, 2023
Closed
@marcalff
Copy link
Copy Markdown
Member Author

marcalff commented Mar 6, 2023

Blocked by:

@ThomsonTan ThomsonTan self-requested a review March 6, 2023 22:21
@marcalff
Copy link
Copy Markdown
Member Author

marcalff commented Mar 22, 2023

Unblocked by:

build-tools 0.18.0 resolves code generation.

@marcalff marcalff removed pr:do-not-merge This PR is not ready to be merged. issue:blocked Fix blocked, waiting for other fixes as prerequisites labels Mar 22, 2023
lalitb
lalitb approved these changes Mar 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@lalitb lalitb added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Mar 22, 2023
@lalitb lalitb merged commit 380f0f2 into open-telemetry:main Mar 27, 2023
@marcalff marcalff changed the title Upgraded semantic conventions to 1.19.0 [SEMANTIC CONVENTIONS] Upgrade to version 1.19.0 Apr 12, 2023
@chuanchan1116 chuanchan1116 mentioned this pull request Apr 19, 2023
Closed
ays7 added a commit to ays7/opentelemetry-cpp that referenced this pull request May 18, 2023
@ays7
Merge v1.9.0
d44532c 
* commit '7887d32da60f54984a597abccbb0c883f3a51649': (82 commits)
  [RELEASE] Release version 1.9.0 (open-telemetry#2091)
  Use sdk_start_ts for MetricData start_ts for instruments having cumulative aggregation temporality. (open-telemetry#2086)
  [SEMANTIC CONVENTIONS] Upgrade to version 1.20.0 (open-telemetry#2088)
  [EXPORTER] Add OTLP HTTP SSL support (open-telemetry#1793)
  Make Windows build environment parallel (open-telemetry#2080)
  make some hints (open-telemetry#2078)
  Make some targets parallel in CI pipeline (open-telemetry#2076)
  [Metrics SDK] Implement Forceflush for Periodic Metric Reader (open-telemetry#2064)
  Upgraded semantic conventions to 1.19.0 (open-telemetry#2017)
  Bump actions/stale from 7 to 8 (open-telemetry#2070)
  Include directory path added for Zipkin exporter example (open-telemetry#2069)
  Ignore more warning of generated protobuf files than not included in `-Wall` and `-Wextra` (open-telemetry#2067)
  Add `ForceFlush` for all `LogRecordExporter`s and `SpanExporter`s. (open-telemetry#2000)
  Remove unused 'alerting' section from prometheus.yml in examples (open-telemetry#2055)
  Clean warnings in ETW exporters (open-telemetry#2063)
  Fix default value of `OPENTELEMETRY_INSTALL_default`. (open-telemetry#2062)
  [EXPORTER] GRPC endpoint scheme should take precedence over OTEL_EXPORTER_OTLP_TRACES_INSECURE (open-telemetry#2060)
  Fix view names in Prometheus example (open-telemetry#2034)
  Fix some docs typo (open-telemetry#2057)
  Checking indices before dereference (open-telemetry#2040)
  ...

# Conflicts:
#	exporters/ostream/CMakeLists.txt
#	sdk/src/metrics/state/metric_collector.cc
#	sdk/src/metrics/state/temporal_metric_storage.cc
@marcalff marcalff deleted the fix_sem_conv_2016 branch July 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan Awaiting requested review from ThomsonTan

Assignees

No one assigned

Labels

ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SEMANTIC CONVENTIONS] Upgrade to version 1.19.0

4 participants

@marcalff @ThomsonTan @lalitb @esigo