[BUILD] Add missing STL header.#2107
Merged
marcalff merged 1 commit intoopen-telemetry:mainfrom Apr 20, 2023
Merged
Conversation
Signed-off-by: owent <admin@owent.net>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
=======================================
Coverage 87.19% 87.19%
=======================================
Files 166 166
Lines 4784 4784
=======================================
Hits 4171 4171
Misses 613 613 |
ThomsonTan
approved these changes
Apr 20, 2023
| # include <future> | ||
| #endif | ||
|
|
||
| #include <functional> |
Contributor
There was a problem hiding this comment.
Wondering why this happens only to clang16 and libc++.
Member
Author
There was a problem hiding this comment.
std::function is in <functional> (https://en.cppreference.com/w/cpp/utility/functional/function).But it may be included by other headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2106
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes