[BUILD] shared libraries with version suffix, along with the symbolic link#2109
Merged
marcalff merged 7 commits intoopen-telemetry:mainfrom Apr 22, 2023
Merged
[BUILD] shared libraries with version suffix, along with the symbolic link#2109marcalff merged 7 commits intoopen-telemetry:mainfrom
marcalff merged 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 87.19% 87.17% -0.02%
==========================================
Files 166 166
Lines 4784 4784
==========================================
- Hits 4171 4170 -1
- Misses 613 614 +1 |
marcalff
reviewed
Apr 21, 2023
Member
marcalff
left a comment
There was a problem hiding this comment.
Using OPENTELEMETRY_ABI_VERSION_NO as SOVERSION looks like the correct choice.
See minor comment on dependent options.
marcalff
approved these changes
Apr 21, 2023
Member
marcalff
left a comment
There was a problem hiding this comment.
LGTM.
To clarify, I don't think opentelemetry-cpp is ready to use shared libraries yet.
We need to make sure the proper symbol is part of the proper library, see issue #1429.
This is however a different issue, which should not prevent this part to go in the main branch.
Ok to merge.
ThomsonTan
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2100
Changes
Versioning policy is described here for debian - https://www.debian.org/doc/debian-policy/ch-sharedlibs.html. In general same is followed across other *nix distributions.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes