Skip to content

[DEPRECATION] Drop C++11 support#2146

Merged
marcalff merged 4 commits intoopen-telemetry:mainfrom
marcalff:deprecate_cpp11_1830
May 23, 2023
Merged

[DEPRECATION] Drop C++11 support#2146
marcalff merged 4 commits intoopen-telemetry:mainfrom
marcalff:deprecate_cpp11_1830

Conversation

@marcalff
Copy link
Copy Markdown
Member

@marcalff marcalff commented May 22, 2023

Fixes #1830

Changes

Announce end of C++11 support for September 2023.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • DEPRECATED.md updated with announcement
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team May 22, 2023 22:43
@codecov
Copy link
Copy Markdown

codecov bot commented May 22, 2023

Codecov Report

Merging #2146 (a1f5998) into main (cfa130b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
- Coverage   87.17%   87.15%   -0.02%     
==========================================
  Files         166      166              
  Lines        4777     4777              
==========================================
- Hits         4164     4163       -1     
- Misses        613      614       +1     

see 1 file with indirect coverage changes

Copy link
Copy Markdown
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

Comment thread DEPRECATED.md Outdated
marcalff and others added 2 commits May 23, 2023 08:46
Co-authored-by: Ehsan Saei <71217171+esigo@users.noreply.github.com>
Reworded to avoid repetitions.
@marcalff marcalff added this to the Migrate to C++14 milestone May 23, 2023
@marcalff marcalff merged commit 61e8741 into open-telemetry:main May 23, 2023
cngzhnp pushed a commit to cngzhnp/opentelemetry-cpp that referenced this pull request May 26, 2023
cngzhnp pushed a commit to cngzhnp/opentelemetry-cpp that referenced this pull request May 26, 2023
cngzhnp pushed a commit to cngzhnp/opentelemetry-cpp that referenced this pull request Jul 4, 2023
cngzhnp pushed a commit to cngzhnp/opentelemetry-cpp that referenced this pull request Jul 10, 2023
@marcalff marcalff deleted the deprecate_cpp11_1830 branch September 5, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DEPRECATION] Drop C++11 support

5 participants