[BUILD] Remove defining NOMINMAX from api#2420
Merged
ThomsonTan merged 3 commits intoopen-telemetry:mainfrom Dec 2, 2023
Merged
[BUILD] Remove defining NOMINMAX from api#2420ThomsonTan merged 3 commits intoopen-telemetry:mainfrom
ThomsonTan merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
==========================================
- Coverage 87.06% 87.04% -0.01%
==========================================
Files 199 199
Lines 6079 6079
==========================================
- Hits 5292 5291 -1
- Misses 787 788 +1
|
lalitb
approved these changes
Dec 1, 2023
marcalff
approved these changes
Dec 2, 2023
Member
marcalff
left a comment
There was a problem hiding this comment.
For the changes in API, totally agree, this is the most robust thing to do.
For the changes in exporters and SDK, I think the changes are not really needed, especially in *.cc because the Windows.h header file is not used and will not cause conflicts, but ok to have the extra parenthesis to have a consistent code.
Even when not needed, this will prevent two different styles to proliferate in the code base with copy and paste.
Approved, thanks for the fix.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, including OpenTelemetry API requires NOMINMAX to be defined for Windows user which excludes the min/max macro from the Windows header files. There are cases when both macros are used by the customer code so requiring NOMINMAX will cause incompatibility. This PR wraps the usage of min/max from C++ standard library with parenthesis. This can avoid the naming conflict with the macro names min/max.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes