[BUILD] Fix old style cast warning

[keith]

Fixes #2556

[lalitb]

Thanks for the fix. Would be also good to add this warning as an error in maintainer mode CI -

opentelemetry-cpp/CMakeLists.txt

Line 469 in ba18304

if(OTELCPP_MAINTAINER_MODE)

, this will reveal if there are other places to fix too.

[keith]

There are actually quite a few more, I will push them and that cmake change here

[keith]

pushed! note there are a few cases where reinterpret_cast was the replacement instead

[keith]

Ok I think this is ready for re-review!

[marcalff]

A few more warnings indeed, thanks for the cleanup.

See a comment on SetCurlPtrOption

[marcalff]

LGTM, thanks for the cleanup.

[marcalff]

@keith Last CI failures are in tests, because of ifdef for ABI_V2.

/home/runner/work/opentelemetry-cpp/opentelemetry-cpp/sdk/test/trace/tracer_provider_test.cc:175:33: error: use of old-style cast [-Werror,-Wold-style-cast]
                          {"d", (unsigned int)314159},

Should be ready to go after this last pass.

[keith]

ah thanks yea i didn't build with that locally, pushed

[marcalff]

@keith Last CI failures are in tests, because of ifdef for ABI_V2.

/home/runner/work/opentelemetry-cpp/opentelemetry-cpp/sdk/test/trace/tracer_provider_test.cc:175:33: error: use of old-style cast [-Werror,-Wold-style-cast]
                          {"d", (unsigned int)314159},

Should be ready to go after this last pass.

Search for "error:" in the CI logs.

Maintainer builds do a make -k to report as many errors as possible in one build, there are a few reported there.

Or build WITH_ABI_VERSION_2 locally (Cmake).

[keith]

thanks!

[marcalff]

Thanks @keith