[EXPORTER] Support URL-encoded values for OTEL_EXPORTER_OTLP_HEADERS#2579
Merged
lalitb merged 8 commits intoopen-telemetry:mainfrom Mar 7, 2024
Merged
[EXPORTER] Support URL-encoded values for OTEL_EXPORTER_OTLP_HEADERS#2579lalitb merged 8 commits intoopen-telemetry:mainfrom
OTEL_EXPORTER_OTLP_HEADERS#2579lalitb merged 8 commits intoopen-telemetry:mainfrom
Conversation
marcalff
requested changes
Mar 7, 2024
Contributor
Author
@marcalff Got it, I reverted the renaming. |
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Mar 7, 2024
Support URL-encoded values for `OTEL_EXPORTER_OTLP_HEADERS` (open-telemetry#2579)
OTEL_EXPORTER_OTLP_HEADERSOTEL_EXPORTER_OTLP_HEADERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2523
Changes
This PR adds support for URL-encoded values in
OTEL_EXPORTER_OTLP_HEADERSand related headers, which is required by the specification.The necessary
url_decodefunction is added toext/include/opentelemetry/ext/http/common/url_parser.h, which was renamed toext/include/opentelemetry/ext/http/common/url_util.hto reflect the change.For backwards compatibility, both URL-encoded and non-URL-encoded values are supported, for example:
CHANGELOG.mdupdated for non-trivial changes