[BUILD] Add support for bzlmod#2608
Conversation
|
this will probably fail CI with the same issue as #2599 |
ea5e310 to
8ba900a
Compare
|
ok I pushed an update here that seems to fix it at least with c++17, it depends on bazelbuild/bazel-central-registry#1810 |
66ae4c3 to
f140acc
Compare
f140acc to
f9c9ce9
Compare
|
Hi @keith Could you merge with a recent main to resolve conflicts, Thanks, |
8f4db8d to
4d070b8
Compare
|
The windows and asan failures here are real. |
|
hopefully will be unblocked by #2679 |
This adds support for bzlmod, which is bazel's new dependency resolution system. Theoretically we could now remove the previous dependency management configuration which required flattening all the dependencies, but I left it here for now for users using old versions of bazel.
4d070b8 to
28c90ff
Compare
|
I think there might still be a grpc ODR issue I have to fix, but we'll see if CI fails |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
==========================================
+ Coverage 87.12% 87.67% +0.55%
==========================================
Files 200 190 -10
Lines 6109 5851 -258
==========================================
- Hits 5322 5129 -193
+ Misses 787 722 -65 |
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the PR.
See minor fixes, and some questions.
f77041e to
1e84d7f
Compare
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution.
|
thanks! |
This adds support for bzlmod, which is bazel's new dependency resolution system.
Theoretically we could now remove the previous dependency management configuration which required flattening all the dependencies, but I left it here for now for users using old versions of bazel.
Fixes: #2334