[API/SDK] Provider cleanup#2664
Merged
marcalff merged 25 commits intoopen-telemetry:mainfrom Jun 3, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
+ Coverage 87.12% 87.68% +0.56%
==========================================
Files 200 190 -10
Lines 6109 5851 -258
==========================================
- Hits 5322 5130 -192
+ Misses 787 721 -66
|
Member
|
Good catch :) |
Member
Author
|
Waiting for the build to finish to make sure DLL links, then this will be ready for review. |
Member
Author
|
Add help-wanted label: The windows DLL build fails with undefined symbols, and I can not figure out why (I don't have windows locally to investigate). |
62 tasks
marcalff
commented
May 27, 2024
lalitb
reviewed
Jun 2, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2506
Changes
Please provide a brief description of the changes here.
Flush()andClose()from theAPIclassopentelemetry::trace::Tracer, starting with ABI version 2.XXXProviderFactory::Create()methods to return anSDKobject instead of anAPIobject.Flush()andShutdown().static_cast<SDK*>(API object)from examples, and use cleaner code, to initialize SDK providers.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes