[BUILD] Read default proto version from third_party_release#2677
Merged
marcalff merged 4 commits intoopen-telemetry:mainfrom May 28, 2024
Merged
[BUILD] Read default proto version from third_party_release#2677marcalff merged 4 commits intoopen-telemetry:mainfrom
third_party_release#2677marcalff merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
==========================================
+ Coverage 87.12% 87.70% +0.58%
==========================================
Files 200 190 -10
Lines 6109 5852 -257
==========================================
- Hits 5322 5132 -190
+ Misses 787 720 -67 |
third_party_releasethird_party_release
marcalff
reviewed
May 23, 2024
marcalff
approved these changes
May 23, 2024
Member
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the fix.
See suggested change.
Not sure why opentelemetry-proto.cmake was not formatted in my previous change, as CI was ok on format.
Member
Author
Maybe we should use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2676
Changes
third_party_releasecmake/opentelemetry-proto.cmakeFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes