[EXPORTER] Fix URL in ES exporter, fix ipv6 supporting for http client.#3081
Merged
marcalff merged 1 commit intoopen-telemetry:mainfrom Oct 7, 2024
Merged
[EXPORTER] Fix URL in ES exporter, fix ipv6 supporting for http client.#3081marcalff merged 1 commit intoopen-telemetry:mainfrom
marcalff merged 1 commit intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
==========================================
+ Coverage 87.12% 87.81% +0.69%
==========================================
Files 200 195 -5
Lines 6109 5968 -141
==========================================
- Hits 5322 5240 -82
+ Misses 787 728 -59
|
marcalff
approved these changes
Oct 7, 2024
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the two fixes.
marcalff
changed the title
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Oct 7, 2024
Fix URL in ES exporter, fix ipv6 supporting for http client. (open-telemetry#3081)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3079
Fixes #3073
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes