[TEST] Fix linking order and gmock linking#3106
Merged
marcalff merged 2 commits intoopen-telemetry:mainfrom Oct 18, 2024
Merged
[TEST] Fix linking order and gmock linking#3106marcalff merged 2 commits intoopen-telemetry:mainfrom
marcalff merged 2 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3106 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
lalitb
approved these changes
Oct 17, 2024
marcalff
approved these changes
Oct 17, 2024
Member
|
LGTM, Waiting a bit, to give the issue reporter a chance to test and confirm the fix works. Ok to merge after that. |
Member
Author
It's tested now. |
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Oct 18, 2024
[TEST] Fix linking order and gmock linking (open-telemetry#3106)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3102
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes