[MAINTAINER] Add devcontainer#3123
Merged
marcalff merged 16 commits intoopen-telemetry:mainfrom Jan 15, 2025
Merged
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 198 198
Lines 6271 6271
=======================================
Hits 5500 5500
Misses 771 771 |
psx95
reviewed
Nov 7, 2024
psx95
reviewed
Nov 7, 2024
owent
reviewed
Dec 19, 2024
marcalff
approved these changes
Jan 15, 2025
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the tooling and doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3118 (issue)
Changes
bazelisk-linux-amd64 test --copt=-DENABLE_LOGS_PREVIEW --test_output=errors --cache_test_results=no --copt=-DENABLE_TEST //exporters/otlp/...bash ci/do_ci.sh cmake.exporter.otprotocol.testFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes