[BUILD] Fix elasticsearch exporter json compatibility#3313
Merged
lalitb merged 5 commits intoopen-telemetry:mainfrom Mar 25, 2025
Merged
[BUILD] Fix elasticsearch exporter json compatibility#3313lalitb merged 5 commits intoopen-telemetry:mainfrom
lalitb merged 5 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
==========================================
+ Coverage 89.50% 89.52% +0.02%
==========================================
Files 210 210
Lines 6522 6522
==========================================
+ Hits 5837 5838 +1
+ Misses 685 684 -1 🚀 New features to boost your workflow:
|
owent
requested changes
Mar 24, 2025
ThomsonTan
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3312
The system package of nlohmann_json is version 3.10.5 on Ubuntu 22.04.
Changes
json_assign_visitorto handlenostd::spanattribute values.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes