[BUILD] Fixes warnings of ciso646 in C++17#3360
Merged
ThomsonTan merged 7 commits intoopen-telemetry:mainfrom Apr 23, 2025
Merged
[BUILD] Fixes warnings of ciso646 in C++17#3360ThomsonTan merged 7 commits intoopen-telemetry:mainfrom
ThomsonTan merged 7 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3360 +/- ##
==========================================
- Coverage 89.57% 89.55% -0.01%
==========================================
Files 210 210
Lines 6505 6505
==========================================
- Hits 5826 5825 -1
- Misses 679 680 +1 🚀 New features to boost your workflow:
|
lalitb
reviewed
Apr 11, 2025
ThomsonTan
reviewed
Apr 14, 2025
73500ee to
8a36161
Compare
ThomsonTan
approved these changes
Apr 15, 2025
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Apr 23, 2025
Fixes warnings of ciso646 in C++17 (open-telemetry#3360)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3359
There will be warning when using
-std=c++17in the trunk version of GCC.The issues were first reported in #3121 (comment) .
Changes
<version>to import feature checking macros in C++20<iso646.h>to avoid warnings in C++17For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes