[CONFIGURATION] File configuration - sdk builder#3550
Merged
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
62 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3550 +/- ##
==========================================
+ Coverage 90.01% 90.03% +0.02%
==========================================
Files 220 220
Lines 7065 7065
==========================================
+ Hits 6359 6360 +1
+ Misses 706 705 -1 🚀 New features to boost your workflow:
|
dbarker
reviewed
Jul 19, 2025
dbarker
reviewed
Jul 19, 2025
dbarker
reviewed
Jul 19, 2025
dbarker
reviewed
Jul 19, 2025
dbarker
reviewed
Jul 19, 2025
dbarker
reviewed
Jul 19, 2025
Member
|
Thanks for the PR @marcalff. Just noted a few nitpicks (optional) and a request to add a test for the ConfiguredSdk class if that is reasonable. |
dbarker
reviewed
Jul 20, 2025
Member
Author
|
@dbarker Thanks for this round of comments. All addressed, PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2481
This is a partial fix, that implements the sdk builder.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes