[TRACE SDK] Batch span processor options now using env variables#3661
[TRACE SDK] Batch span processor options now using env variables#3661marcalff merged 17 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3661 +/- ##
==========================================
+ Coverage 90.11% 90.18% +0.07%
==========================================
Files 221 222 +1
Lines 7135 7154 +19
==========================================
+ Hits 6429 6451 +22
+ Misses 706 703 -3
🚀 New features to boost your workflow:
|
marcalff
left a comment
There was a problem hiding this comment.
Some changes needed:
The header file exposes implementation details, which are compiled into the application binary.
Move every implementation details, including default values, helpers, names of environment variables, to batch_span_processor_options.cc
See existing options structures for the pattern.
|
@marcalff Applied the above changes, Thanks! But the BatchSpanProcessor does not have the field of |
sdk/include/opentelemetry/sdk/trace/batch_span_processor_options.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/trace/batch_span_processor_options.h
Outdated
Show resolved
Hide resolved
marcalff
left a comment
There was a problem hiding this comment.
Looking much better.
See minor cleanup,
I will approve once I can verify the changes.
|
@marcalff @nikhilbhatia08, this PR breaks a bunch of existing code without providing a sensible alternative. Prior to that we were using the following syntax using C++20 aggregate initialization: It does not seem that there is a sensible rewrite of this code. |
|
NB: #3687 has the same problem |
|
I believe the issue comes from adding a user-defined constructor, which means |
|
Seems like a solution to me! |
Fixes #2085
Using this change we can get
max_queue_sizeschedule_delayexport_timeoutmax_export_batch_sizeusing environment variables. BatchSpanProcessor still does not useexport_timeoutand tests have been added.Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes