[CONFIGURATION] File configuration - parser location#3705
Merged
marcalff merged 4 commits intoopen-telemetry:mainfrom Oct 20, 2025
Merged
[CONFIGURATION] File configuration - parser location#3705marcalff merged 4 commits intoopen-telemetry:mainfrom
marcalff merged 4 commits intoopen-telemetry:mainfrom
Conversation
62 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3705 +/- ##
==========================================
+ Coverage 89.95% 90.00% +0.05%
==========================================
Files 225 225
Lines 7273 7273
==========================================
+ Hits 6542 6545 +3
+ Misses 731 728 -3 🚀 New features to boost your workflow:
|
dbarker
reviewed
Oct 19, 2025
dbarker
approved these changes
Oct 19, 2025
Member
dbarker
left a comment
There was a problem hiding this comment.
Looks good. Thanks! one very minor / optional nitpick
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2481
This is a partial fix, to implement parser location, for better yaml error messages.
Changes
Please provide a brief description of the changes here.
Implement the "Location" of a yaml node in the parser
Implement a location property in yaml related exceptions
Change all the parsing code to pass the current yaml node as context, in case code needs to access a node location to raise an exception.
With all these changes, when the parser fails with an invalid schema exception, the exception contains:
This helps ease of use, so error messages about invalid config.yaml files point precisely at the error location.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes