Skip to content

[SDK] Add cardinality_limit to all derived classes of AggregationConfig #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcalff merged 2 commits into from
Oct 30, 2025
Merged

[SDK] Add cardinality_limit to all derived classes of AggregationConfig #3728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea6ea91
Add cardinality_limit to all derived classes of AggregationConfig
ThomsonTan Oct 29, 2025
0e61dca
Format
ThomsonTan Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sdk/include/opentelemetry/sdk/metrics/aggregation/aggregation_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,22 @@ class AggregationConfig
class HistogramAggregationConfig : public AggregationConfig
{
public:
HistogramAggregationConfig(size_t cardinality_limit = kAggregationCardinalityLimit)
: AggregationConfig(cardinality_limit)
{}

std::vector<double> boundaries_;
bool record_min_max_ = true;
};

class Base2ExponentialHistogramAggregationConfig : public AggregationConfig
{
public:
Base2ExponentialHistogramAggregationConfig(
size_t cardinality_limit = kAggregationCardinalityLimit)
: AggregationConfig(cardinality_limit)
{}

size_t max_buckets_ = 160;
int32_t max_scale_ = 20;
bool record_min_max_ = true;
Expand Down
Loading