Enable WITH_OTLP_GRPC_SSL_MTLS_PREVIEW by default#3970
Enable WITH_OTLP_GRPC_SSL_MTLS_PREVIEW by default#3970marcalff merged 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3970 +/- ##
==========================================
+ Coverage 90.17% 90.18% +0.02%
==========================================
Files 230 230
Lines 7298 7298
==========================================
+ Hits 6580 6581 +1
+ Misses 718 717 -1 🚀 New features to boost your workflow:
|
|
One high-level concern: if the goal here is to deprecate Right now this change moves CMake in that direction, but Bazel still seems not to expose the mTLS-specific API surface. That leaves the feature behavior/build surface inconsistent across build systems during the deprecation period. If the intended end state is unconditional support, I think it would be good either to align Bazel in the same PR or explicitly call out that this PR is only the CMake side of that transition. |
I agree, not too happy with the CMake / Bazel lack of symmetry either. I revised the bazel build to always define Note that there is no opt-out flag for bazel, because no flag was ever exposed, unlike CMake. PTAL. If this is satisfactory, I will revise |
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Thanks for handling bazel too in this PR.
Co-authored-by: Tom Tan <lilotom@gmail.com>
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
WITH_OTLP_GRPC_SSL_MTLS_PREVIEWby default in CMake.ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEWin bazel.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes