Skip to content

Fix missing include dir for configure_package_config_file#514

Merged
lalitb merged 3 commits intoopen-telemetry:masterfrom
ThomsonTan:FixFindPackage
Jan 21, 2021
Merged

Fix missing include dir for configure_package_config_file#514
lalitb merged 3 commits intoopen-telemetry:masterfrom
ThomsonTan:FixFindPackage

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

@ThomsonTan ThomsonTan commented Jan 13, 2021

This fixes #513 by passing the missing INCLUDE_INSTALL_DIR to configure_package_config_file as PATH_VARS.

@ThomsonTan ThomsonTan requested a review from a team January 13, 2021 05:00
@ThomsonTan ThomsonTan changed the title Fixing missing include dir for configure_package_config_file Fix missing include dir for configure_package_config_file Jan 13, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2021

Codecov Report

Merging #514 (a4a60f8) into master (4a13db9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         189      189           
  Lines        8388     8388           
=======================================
  Hits         7924     7924           
  Misses        464      464           
Impacted Files Coverage Δ
sdk/test/common/circular_buffer_test.cc 98.97% <0.00%> (-1.03%) ⬇️
sdk/test/metrics/counter_aggregator_test.cc 100.00% <0.00%> (+1.78%) ⬆️

@ThomsonTan ThomsonTan added bug Something isn't working and removed bug Something isn't working labels Jan 13, 2021
@ThomsonTan ThomsonTan added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jan 20, 2021
@lalitb lalitb merged commit d65d7c0 into open-telemetry:master Jan 21, 2021
@ThomsonTan ThomsonTan deleted the FixFindPackage branch November 9, 2022 22:53
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Mar 6, 2026
…and-patch-dependencies

Update all minor and patch dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake find_package failed to import opentelemetry-cpp

3 participants