Set default service.name if missing#616
Merged
lalitb merged 3 commits intoopen-telemetry:mainfrom Mar 22, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #616 +/- ##
==========================================
- Coverage 94.51% 94.50% -0.02%
==========================================
Files 197 197
Lines 9101 9131 +30
==========================================
+ Hits 8602 8629 +27
- Misses 499 502 +3
|
ThomsonTan
reviewed
Mar 19, 2021
ThomsonTan
approved these changes
Mar 19, 2021
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Mar 6, 2026
…and-patch-dependencies Update all minor and patch dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
The
service.nameattribute of Resource is mandatory and SDK should set the default value if not specified. This attribute is necessary for certain backends to identify the service that produced the spans.as in specs:
MUST be the same for all instances of horizontally scaled services. If the value was not specified, SDKs MUST fallback to unknown_service: concatenated with process.executable.name, e.g.
unknown_service:bash. If process.executable.name is not available, the value MUST be set tounknown_service.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes