Support Custom span-id and trace-id generator#681
Merged
lalitb merged 11 commits intoopen-telemetry:mainfrom Apr 21, 2021
Merged
Support Custom span-id and trace-id generator#681lalitb merged 11 commits intoopen-telemetry:mainfrom
lalitb merged 11 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
==========================================
+ Coverage 94.64% 94.67% +0.02%
==========================================
Files 206 208 +2
Lines 9382 9407 +25
==========================================
+ Hits 8880 8906 +26
+ Misses 502 501 -1
|
eyjohn
approved these changes
Apr 19, 2021
Contributor
eyjohn
left a comment
eyjohn
left a comment
There was a problem hiding this comment.
Overall looks great to land, some minor nitpicks,
Minor question about constness
| /** | ||
| * A Mock Custom Id Generator | ||
| */ | ||
| class MockIdGenerator : public IdGenerator |
Contributor
There was a problem hiding this comment.
nit: Google Mock would be great to use here, I noticed we don't have it in the repo but EXPECT_CALL and return values can all be done in the test body which would be nice
pyohannes
reviewed
Apr 19, 2021
ThomsonTan
reviewed
Apr 20, 2021
Co-authored-by: Tom Tan <lilotom@gmail.com>
…y-cpp into custom-id-generation
…y-cpp into custom-id-generation
ThomsonTan
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #677
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes