Merged
Conversation
Signed-off-by: owent <admin@owent.net>
Signed-off-by: owent <admin@owent.net>
Codecov Report
@@ Coverage Diff @@
## main #835 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 156 156
Lines 6619 6619
=======================================
Hits 6321 6321
Misses 298 298
|
maxgolov
approved these changes
Jun 8, 2021
Contributor
maxgolov
left a comment
There was a problem hiding this comment.
LGTM. Thank you! Maybe we'd need to add some CI for that (in a separate PR).
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owent admin@owent.net
Fixes #834
Changes
TSAN_OPTIONS=report_atomic_races=0, which is just the same as grpc.Shall we add a CI job to build and install opentelemetry-cpp, and then try to import components from cmake config?
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes