Skip to content

Rename Recordable to JaegerRecordable in Jaeger exporter#919

Merged
lalitb merged 3 commits intoopen-telemetry:mainfrom
ThomsonTan:RenameJaegerExporter
Jul 21, 2021
Merged

Rename Recordable to JaegerRecordable in Jaeger exporter#919
lalitb merged 3 commits intoopen-telemetry:mainfrom
ThomsonTan:RenameJaegerExporter

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

Fixes #735

Changes

The Recordable applies to Jaeger exporter. The concrete protocols are abstracted to the ThriftSender, so no need to include the protocol name here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team July 21, 2021 17:13
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2021

Codecov Report

Merging #919 (3432d7a) into main (2b3fe84) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   95.44%   95.43%   -0.01%     
==========================================
  Files         158      158              
  Lines        6749     6749              
==========================================
- Hits         6441     6440       -1     
- Misses        308      309       +1     
Impacted Files Coverage Δ
...include/opentelemetry/sdk/common/circular_buffer.h 97.92% <0.00%> (-2.08%) ⬇️

@lalitb lalitb merged commit afcb08e into open-telemetry:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renaming SDK Recordable class name to reflect the underlying transport

2 participants