remove recordable header from CMake install rules for exporters#923
Merged
lalitb merged 2 commits intoopen-telemetry:mainfrom Jul 26, 2021
Merged
remove recordable header from CMake install rules for exporters#923lalitb merged 2 commits intoopen-telemetry:mainfrom
lalitb merged 2 commits intoopen-telemetry:mainfrom
Conversation
lalitb
changed the title
ThomsonTan
approved these changes
Jul 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 158 158
Lines 6749 6749
=======================================
Hits 6441 6441
Misses 308 308 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As discussed here ( #922 (comment) ), exporter specific recordable.h shouldn't be included in the exporter's install targets. This header shouldn't be used by application developers. So this PR excludes this header from the exporter's install rule.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes