🐛 Fix for Stack::Resize that new_capacity is not assigned to capacity_#934
Merged
lalitb merged 3 commits intoopen-telemetry:mainfrom Aug 3, 2021
nemoyuan:fix_stack_resize_cap
Merged
🐛 Fix for Stack::Resize that new_capacity is not assigned to capacity_#934lalitb merged 3 commits intoopen-telemetry:mainfrom nemoyuan:fix_stack_resize_cap
lalitb merged 3 commits intoopen-telemetry:mainfrom
nemoyuan:fix_stack_resize_cap
Conversation
Contributor
Author
Member
Yes, there is a problem with easyCLA validation: open-telemetry/community#795 |
Codecov Report
@@ Coverage Diff @@
## main #934 +/- ##
==========================================
+ Coverage 95.36% 95.36% +0.01%
==========================================
Files 160 160
Lines 6779 6780 +1
==========================================
+ Hits 6464 6465 +1
Misses 315 315
|
Member
|
@Yerannnnnn - Can you try to authorize yourself for easyCLA now? |
lalitb
approved these changes
Aug 2, 2021
ThomsonTan
approved these changes
Aug 2, 2021
Contributor
Author
@lalitb Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix for Stack::Resize that new_capacity is not assigned to capacity_ , caused stack to constantly allocate memory when size_>0.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes