Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
=======================================
Coverage 68.42% 68.42%
=======================================
Files 220 220
Lines 5989 5989
Branches 981 981
=======================================
Hits 4098 4098
+ Misses 1619 1617 -2
- Partials 272 274 +2
|
CodeBlanch
approved these changes
Aug 5, 2020
Member
CodeBlanch
left a comment
There was a problem hiding this comment.
LGTM! Issue with the sampler is we only currently allow true/false response but by the spec there should be 3 states?
Member
Author
That's already showing the value of having these simple tutorials - if we're unhappy with the tutorial projects, we know we got to fix something 😄. |
Member
It's tracked as an issue tagged p1 for coming release. @rajkumar-rangaraj will be working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very similar to #996.
Trying to use the docs and tutorial projects to drive for better design and implementation.
This change should give us some idea about the sampler use case.
Changes