Feature: Activity Filter capability for OpenTelemetry.Instrumentation.SqlClient #3342
Closed
jvinters wants to merge 6 commits intoopen-telemetry:mainfrom
jvinters:sqlclient-activity-filter
Closed
Feature: Activity Filter capability for OpenTelemetry.Instrumentation.SqlClient #3342jvinters wants to merge 6 commits intoopen-telemetry:mainfrom jvinters:sqlclient-activity-filter
jvinters wants to merge 6 commits intoopen-telemetry:mainfrom
jvinters:sqlclient-activity-filter
Conversation
jvinters
changed the title
cijothomas
reviewed
Jun 9, 2022
| { | ||
| if (this.options.EventFilter(activity, "OnCustom", command) == false) | ||
| { | ||
| SqlClientInstrumentationEventSource.Log.FilterException(activity.OperationName); |
Contributor
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Contributor
|
@cijothomas would it be possible to reopen this PR? Happy to help with any outstanding issues. Your comment above re: possible exception was the only issue? |
Member
Contributor
|
@cijothomas @jvinters are we deadlocked here? |
Member
|
@Driedas You can open a new PR, and mention this PR in the description. Thanks. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Related: #2020, open-telemetry/opentelemetry-dotnet-contrib#1757
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes