Logging state during building of TracerProvider by ggoel · Pull Request #3746 · open-telemetry/opentelemetry-dotnet

ggoel · 2022-10-09T12:29:18Z

Changes

Logging state during building of TracerProvider.

For significant contributions please make sure you have completed the following items:

Appropriate CHANGELOG.md updated for non-trivial changes
Design discussion issue #
Changes in public API reviewed

utpilla · 2022-10-10T16:18:52Z

@ggoel Thanks for adding diagnostic logging for TracerProviderSdk. The PR looks good. Could you please fix the build errors?

codecov · 2022-10-10T17:01:18Z

Codecov Report

Merging #3746 (aa95196) into main (8db45a3) will increase coverage by 0.35%.
The diff coverage is 100.00%.

❗ Current head aa95196 differs from pull request most recent head b8c469f. Consider uploading reports for the commit b8c469f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3746      +/-   ##
==========================================
+ Coverage   86.95%   87.31%   +0.35%     
==========================================
  Files         278      277       -1     
  Lines       10151    10082      -69     
==========================================
- Hits         8827     8803      -24     
+ Misses       1324     1279      -45

Impacted Files	Coverage Δ
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs	`80.15% <100.00%> (+0.32%)`	⬆️
src/OpenTelemetry/Trace/TracerProviderSdk.cs	`99.63% <100.00%> (+0.01%)`	⬆️
...ry/Metrics/ExplicitBucketHistogramConfiguration.cs	`61.11% <0.00%> (-22.23%)`	⬇️
...OpenTelemetry/Metrics/MetricStreamConfiguration.cs	`65.00% <0.00%> (-10.00%)`	⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs	`73.52% <0.00%> (-5.89%)`	⬇️
src/OpenTelemetry/Metrics/MetricReaderExt.cs	`84.54% <0.00%> (-1.82%)`	⬇️
src/OpenTelemetry/Metrics/Metric.cs	`94.38% <0.00%> (-1.13%)`	⬇️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs	`89.90% <0.00%> (-0.98%)`	⬇️
src/OpenTelemetry/Metrics/MetricStreamIdentity.cs	`90.00% <0.00%> (-0.63%)`	⬇️
...tryProtocol/Implementation/MetricItemExtensions.cs	`93.83% <0.00%> (-0.13%)`	⬇️
... and 10 more

cijothomas · 2022-10-14T21:25:09Z

src/OpenTelemetry/Trace/TracerProviderSdk.cs

                serviceProvider,
                state);

+            StringBuilder processorsAdded = new StringBuilder();


please also include sampler, as it is often the most critical information.

@cijothomas sure, will raise another PR for this

cijothomas

LGTM except https://github.com/open-telemetry/opentelemetry-dotnet/pull/3746/files#r996169712

Its okay to have it as follow up. Let us know if you can add it to this one, or separate one.

cijothomas · 2022-10-14T21:33:43Z

lets merge. this is already an improvement! Could you follow up with a PR adding Samplers?

* [Logs] Fix buffered log scopes being reused (#3731) * Fix buffered log scopes being reused. * CHANGELOG update. * Test fixes. Co-authored-by: Cijo Thomas <cithomas@microsoft.com> * clarify that Prometheus HttpListner is not for production at this moment (#3737) * [HttpClient] Export spans corresponding to retries (#3732) * Minor update to OTLP readme (#3739) * Nit fixes to prometheus readme * Add minor clarification about OTLP logs * Update workflow (#3741) * Minor improvement to log message (#3742) * [SDK + Jaeger] Support loading environment variables from IConfiguration in Traces & Metrics (#3720) * Support retrieval of environment variables through IConfiguration in SDK. * Update Jaeger to load environment variables through IConfiguration. * Warning fix. * CHANGELOG patch. * Bug fixes. * Warning cleanup. * Code review. * [Zipkin] Support loading envvars from IConfiguration (#3759) * Support loading envvars from IConfiguration in Zipkin exporter. * CHANGELOG patch. * SqlClient Instrumentation to leverage native Activity Status. (#3751) * [Metrics] Update default buckets for Explicit Bucket Histogram from spec (#3722) * [Logs] Fix: Respect AttributeValueLengthLimit when building otlp LogRecord data (#3684) * Respect SdkConfiguration.AttributeValueLengthLimit so otlp data points are not rejected by monitoring tools * Respect maxAttributeCount and use OtlpKeyValueTransformer in AddStringAttribute and in AddIntAttribute * Extend CHANGELOG.md Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com> * Bump actions/setup-dotnet from 3.0.1 to 3.0.2 (#3764) Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v3.0.1...v3.0.2) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Repo] Attempting to stabilize the API Compatibility CI job (#3766) * Attempting to stablize the API Compatibility CI. * Tweak. * More logging. * Increase build logging level for api compat ci job. * Tweak. * Tweak. * Revert extra logging in ci job. * Switched some logging back to debug. * Adding MinMax to Histograms (#2735) * Logging state during building of TracerProvider (#3746) * [HttpClient] Add unit tests for `RecordException` case (#3761) * Add a separate example project for Logs redaction (#3744) * Update CHANGELOG for 1.4.0-beta.2 release (#3772) * [SDK + Otlp] Support loading envvars from IConfiguration (#3760) * Updated Otlp Trace & Metrics exporters to load envvars from IConfiguration. * Patch CHANGELOGs. * Fix up otlp log exporter for SdkOptions changes. * Revert SdkOptions public api. * Restore tests. * Fix benchmarks. * SdkLimitOptions IConfiguration test. * OtlpExporterOptions IConfiguration test. * MetricReaderOptions IConfiguration test. * Bug fix. * Nit. * [SqlClient] Add support for Filter expression (#3743) * [SDK, Jaeger, Zipkin, & Otlp] Support loading envvars for BatchExportActivityProcessorOptions from IConfiguration (#3776) * Support loading envvars for ExportActivityProcessorOptions & BatchExportActivityProcessorOptions from IConfiguration. * Update src/OpenTelemetry/CHANGELOG.md Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com> * Patch CHANGELOG. * Unit test. Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com> * Remove Env from CI `DOTNET_MULTILEVEL_LOOKUP = 1` (#3779) * Link to .NET docs about different ports (#3704) * Update DS to rc2 (#3781) * ConsoleLogExporter to output full exception (#3784) * [ASP.NET Core] Add back netstandard2.0 and 2.1 targets (#3755) * [HttpClient] Add back netstandard2.0 target (#3787) * Add back netstandard2.0 target * changelog * public api files * Bump System.Text.Json version due to CVE-2021-26701 (#3789) * Auto-generated Semantic Conventions (#2069) * [SDK] Support dependency injection in ResourceBuilder and load envvars from IConfiguration (#3782) * Add Vishwesh as an Approver (#3783) Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> * Move more SDK docs to docs folder (#3794) * [Prometheus AspNetCore] Support named options in pipeline extensions (#3780) * Support named options in Prometheus AspNetCore pipeline extensions. * Patch CHANGELOG. Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> * [Logs] UnitTest: LogRecord attribute limits (#3758) * Unittest for LogRecord attribute limits * Remove maxValueLength from LogRecordExtensions.AddIntAttribute. Change requested from #3684 (comment) * Pr commits addressed Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com> * Add MinMax to console and doc additions (#3795) * Mark private and internal classes as sealed (#3799) Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> * Move more docs to docs folder (#3801) * [ASP.NET Core] Update enrich callbacks to use specific type. (#3749) * [Http] Update enrich callbacks for http (#3792) * [SDK] Support dependency injection in the GetDefaultResource API (#3798) * Support dependency injection in the GetDefaultResource API. * CHANGELOG patch. * Test tweaks. Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> * Fix circular reference issue building up tracer provider. (#3803) * [SDK] Add some missing nullable annotations (#3796) * Added some missing nullable annotations in SDK. * Handle null span names in SamplingParameters. * Warning cleanup. * Warning cleanup. * Added link to issue in comment. Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com> * Guard.Range now uses invariant culture for error message (#3778) Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com> * Fix circular reference issue building up meter provider. (#3806) Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com> * Add missing end of code block backticks (#3807) * More doc tweaks (#3805) * More doc tweaks * remove draft staatus * Update grpc client enrich callbacks (#3804) * Port refactor from main-logs branch. (#3808) Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> * Merge fixes. * Merge fixes. * Merge fix. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> Co-authored-by: Yun-Ting Lin <yunl@microsoft.com> Co-authored-by: Sebastian Schoder Moreno <35150382+schoder-moreno@users.noreply.github.com> Co-authored-by: Jonathan Wilhelm <Jonathan.wilhelm@sage.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Maxwell <micmax@microsoft.com> Co-authored-by: ggoel <gaurav.goel111@gmail.com> Co-authored-by: Utkarsh Umesan Pillai <utpilla@microsoft.com> Co-authored-by: Pavel Steinl <pavel.steinl@gmail.com> Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com> Co-authored-by: aristotelos <arisvd@gmail.com> Co-authored-by: Joao Grassi <joao@joaograssi.com> Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com> Co-authored-by: benhall_io <3179852+benbhall@users.noreply.github.com>

ggoel marked this pull request as ready for review October 9, 2022 12:31

ggoel requested a review from a team October 9, 2022 12:31

ggoel force-pushed the fix_3644 branch from f21cd5f to a649fc4 Compare October 10, 2022 16:38

utpilla approved these changes Oct 10, 2022

View reviewed changes

Kielek approved these changes Oct 11, 2022

View reviewed changes

ggoel added 2 commits October 13, 2022 22:29

Logging state during building of TracerProvider

12611f6

removing extra blank line

7673695

ggoel force-pushed the fix_3644 branch from aa95196 to 7673695 Compare October 13, 2022 16:59

Merge branch 'main' into fix_3644

b8c469f

cijothomas reviewed Oct 14, 2022

View reviewed changes

cijothomas approved these changes Oct 14, 2022

View reviewed changes

cijothomas merged commit 6d5dd37 into open-telemetry:main Oct 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logging state during building of TracerProvider#3746

Logging state during building of TracerProvider#3746
cijothomas merged 3 commits intoopen-telemetry:mainfrom
ggoel:fix_3644

ggoel commented Oct 9, 2022

Uh oh!

utpilla commented Oct 10, 2022

Uh oh!

codecov bot commented Oct 10, 2022 •

edited

Loading

Uh oh!

cijothomas Oct 14, 2022

Uh oh!

ggoel Oct 15, 2022

Uh oh!

cijothomas left a comment

Uh oh!

cijothomas commented Oct 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ggoel commented Oct 9, 2022

Changes

Uh oh!

utpilla commented Oct 10, 2022

Uh oh!

codecov bot commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cijothomas Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

ggoel Oct 15, 2022

Choose a reason for hiding this comment

Uh oh!

cijothomas left a comment

Choose a reason for hiding this comment

Uh oh!

cijothomas commented Oct 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Oct 10, 2022 •

edited

Loading