Skip to content

[Repo] Revert OpenTelemetry.Instrumentation.AspNet OpenTelemetry.proj change#3811

Merged
alanwest merged 1 commit intoopen-telemetry:mainfrom
CodeBlanch:proj-cleanup
Oct 24, 2022
Merged

[Repo] Revert OpenTelemetry.Instrumentation.AspNet OpenTelemetry.proj change#3811
alanwest merged 1 commit intoopen-telemetry:mainfrom
CodeBlanch:proj-cleanup

Conversation

@CodeBlanch
Copy link
Copy Markdown
Member

It looks like #2069 added a rule for OpenTelemetry.Instrumentation.AspNet (which was moved to contrib a while back) to OpenTelemetry.proj. Reverting that bit.

@CodeBlanch CodeBlanch requested a review from a team October 24, 2022 21:04
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2022

Codecov Report

Merging #3811 (38a7962) into main (6ce883b) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3811      +/-   ##
==========================================
+ Coverage   87.40%   87.44%   +0.04%     
==========================================
  Files         280      280              
  Lines       10755    10755              
==========================================
+ Hits         9400     9405       +5     
+ Misses       1355     1350       -5     
Impacted Files Coverage Δ
...tpListener/Internal/PrometheusCollectionManager.cs 73.62% <0.00%> (-2.20%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 96.21% <0.00%> (+1.08%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 95.00% <0.00%> (+10.00%) ⬆️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 86.36% <0.00%> (+13.63%) ⬆️

@alanwest alanwest merged commit c5cb95e into open-telemetry:main Oct 24, 2022
@CodeBlanch CodeBlanch deleted the proj-cleanup branch October 24, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants