Limit character set according to spec#3821
Merged
cijothomas merged 4 commits intoopen-telemetry:mainfrom Oct 28, 2022
mic-max:instrument-naming
Merged
Limit character set according to spec#3821cijothomas merged 4 commits intoopen-telemetry:mainfrom mic-max:instrument-naming
cijothomas merged 4 commits intoopen-telemetry:mainfrom
mic-max:instrument-naming
Conversation
reyang
approved these changes
Oct 25, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3821 +/- ##
==========================================
+ Coverage 87.46% 87.48% +0.01%
==========================================
Files 280 280
Lines 10767 10767
==========================================
+ Hits 9417 9419 +2
+ Misses 1350 1348 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
\wmatches to more than just the intendeda-zA-Z0-9_https://learn.microsoft.com/en-us/dotnet/standard/base-types/character-classes-in-regular-expressions#word-character-wBefore the change the addition to
InvalidInstrumentNameswould fail the test. the value isaµ. The Micro is consideredLetter, Lowercaseby the\wmatch. But this is just to show that any character belonging to the categories shown could have made an instrument name become out of spec.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes